Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INSERT's are failing for long table names 115 #116

Merged
merged 3 commits into from
Sep 15, 2023
Merged

INSERT's are failing for long table names 115 #116

merged 3 commits into from
Sep 15, 2023

Conversation

ahilmer
Copy link
Contributor

@ahilmer ahilmer commented Sep 11, 2023 •
edited
Loading

Ticket

#115

Idea

Use postgres pg_get_serial_sequence function to fetch the real sequence name.

Changes

Please see individual commits for the approach.

Example

Before: Sequence names are different

Selection_883

After: Sequence name match

Selection_886

@ahilmer ahilmer mentioned this pull request Sep 11, 2023
Closed
@ahilmer
Copy link
Contributor Author

ahilmer commented Sep 12, 2023

Hi @sasharevzin thanks for checking!

I am unable to merge this PR, do you have rights to merge or how can we proceed here? 😃

@shayonj
Copy link
Owner

shayonj commented Sep 12, 2023

Thanks for the PR and reviews folks. I will get back in a few days max.

shayonj
shayonj approved these changes Sep 15, 2023
View reviewed changes
Copy link
Owner

@shayonj shayonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shayonj shayonj merged commit a35d363 into shayonj:main Sep 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayonj shayonj shayonj approved these changes

@sasharevzin sasharevzin sasharevzin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahilmer @shayonj @sasharevzin